Merged
Conversation
duncanista
reviewed
Feb 27, 2025
duncanista
reviewed
Feb 27, 2025
duncanista
reviewed
Feb 28, 2025
astuyve
reviewed
Feb 28, 2025
alexgallotta
force-pushed
the
add-startup-info
branch
from
c7c4b30 to
8a4fc53
Compare
astuyve
reviewed
Feb 28, 2025
duncanista
reviewed
Mar 3, 2025
|
|
||
| enable_logging_subsystem(&config); | ||
| let client = reqwest::Client::builder().no_proxy().build().map_err(|e| { | ||
| let version_without_next = EXTENSION_VERSION.split('-').next().unwrap_or("NA"); |
Contributor
Author
There was a problem hiding this comment.
it was because the print was done before the fallback code.
It might still be clearer to avoid adding the -next suffix since it's not how we present the versions, but I don't really have a strong opinion on that, happy to change if you think it's more clean
also fixed import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing a debug line like
at start